Revert "Some fixes for summary, show, and map for non-1 indices" #17769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Having trouble reproducing the failure locally so maybe it's an intermittent thing. |
|
Note that the linked failure is on my WIP pr. So it could be caused by that PR. |
|
Yeah I think I didn't call this one right. Once in a while we do see PR's that pass when CI runs on them, but fail after merged into master because of some other change that got merged in the interim, but this probably was not one of those cases. |
|
This was a pretty unlikely one to cause trouble---anything that touches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #17729
e.g. https://ci.appveyor.com/project/JuliaLang/julia/build/1.0.4947/job/bywb4b7b1vmo5fc4